Fix bug in conditionaltheory for xunit3 and add Helix SDK support#16537
Merged
agocke merged 6 commits intodotnet:mainfrom Feb 23, 2026
Merged
Fix bug in conditionaltheory for xunit3 and add Helix SDK support#16537agocke merged 6 commits intodotnet:mainfrom
agocke merged 6 commits intodotnet:mainfrom
Conversation
The xunit3 discovery code didn't properly pass down the test method arguments, meaning that theories didn't work properly in xunit3 with ConditionalTheory. This PR simplifies things by moving away from the Discovery implementation entirely in xunit3. The modern fact/theory implementations in xunit3 are fine for implementing the functionality we want. The only thing we can't do in the new system is ConditionalTheory with only a member name. I've added an obsolete attribute for those cases. It looks like there are relatively few in use and should be easily moved over when adopting xunit3.
Member
Author
|
Cc @elinor-fung |
akoeplinger
reviewed
Feb 20, 2026
src/Microsoft.DotNet.XUnitExtensions.Shared/Attributes/ConditionalTheoryAttribute.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.XUnitV3Extensions/tests/AlphabeticalOrderer.cs
Outdated
Show resolved
Hide resolved
Updated summary comment to clarify the purpose of ordering test cases.
Member
Author
|
FYI this is blocking more adoption of xunit3 in dotnet/runtime, so it would it be great if it could get merged soon. |
akoeplinger
previously approved these changes
Feb 22, 2026
The new Microsoft.DotNet.XUnitV3Extensions.Tests project was being picked up by the XUnitProject glob in UnitTests.proj and run with the XUnit v2 console runner. XUnit v3 tests are self-hosting executables and cannot use the v2 runner, causing the FailingXUnitTestsTest work item's expected failure (ExerciseXunitCharacterFilteringFailurePath) to be disrupted. This adds proper XUnitV3Project support to the Helix SDK: - XUnitV3Runner.props/targets: restore, build, and create work items for XUnit v3 self-hosting test projects - CreateXUnitV3WorkItems task: generates dotnet exec commands that run the test assembly directly (no external console runner needed) - UnitTests.proj: moves the v3 test project from XUnitProject to XUnitV3Project Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
tests weren't running because of #16536, that uncovered that we didn't run any xunitv3 tests here before with the Helix sdk. I asked Copilot to add support. |
Add UseMicrosoftTestingPlatformRunner property to CreateXUnitV3WorkItems task and XUnitV3Runner.targets. When true (the default, matching Arcade SDK's XUnitV3.targets), uses MTP-style arguments (--report-xunit, --auto-reporters off). When false, uses legacy arguments (-xml, -noAutoReporters). Also removes the forced UseMicrosoftTestingPlatformRunner=false from the publish/restore MSBuild invocations so the project's own MTP default flows through. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add XUnit v3 runner documentation to the Helix SDK Readme.md and SendingJobsToHelix.md, describing XUnitV3Project items and the UseMicrosoftTestingPlatformRunner property. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ViktorHofer
approved these changes
Feb 23, 2026
Youssef1313
reviewed
Feb 23, 2026
| ? "--results-directory . --report-xunit --report-xunit-filename testResults.xml --auto-reporters off" | ||
| : "-xml testResults.xml -noAutoReporters"; | ||
|
|
||
| string command = $"{PathToDotnet} exec --roll-forward Major " + |
Member
There was a problem hiding this comment.
@agocke This will run using the Architecture of the resolved dotnet right? So if a project sets RuntimeIdentifier to force apphost with specific architecture, that won't be respected?
Youssef1313
reviewed
Feb 23, 2026
| { | ||
| { "Identity", assemblyName }, | ||
| { "PayloadDirectory", publishDirectory }, | ||
| { "Command", command }, |
Member
There was a problem hiding this comment.
Should we simplify this to basically just use RunCommand and RunArguments MSBuild properties (after running ComputeRunArguments target)?
This also makes sure that stuff like TestingPlatformCommandLineArguments are considered, and ensures we are using the apphost instead of dotnet exec
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Feb 25, 2026
Required for xunit v3 and the other ctor is marked obsolete as of dotnet/arcade#16537
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
…24791) Required for xunit v3 and the other ctor is marked obsolete as of dotnet/arcade#16537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xunit3 discovery code didn't properly pass down the test method arguments, meaning that theories didn't work properly in xunit3 with ConditionalTheory.
This PR simplifies things by moving away from the Discovery implementation entirely in xunit3. The modern fact/theory implementations in xunit3 are fine for implementing the functionality we want.
The only thing we can't do in the new system is ConditionalTheory with only a member name. I've added an obsolete attribute for those cases. It looks like there are relatively few in use and should be easily moved over when adopting xunit3.
To double check: