Re-enable running of Helix tests#16536
Merged
ViktorHofer merged 5 commits intodotnet:mainfrom Feb 21, 2026
Merged
Conversation
Member
|
Uh are you saying that I broke running tests in Arcade a while ago? |
Member
Author
Unfortunately yes, but nothing/nobody caught it. I discovered this with #16530. I noticed no test results and very quick PR validation times. |
Member
|
Damn, thanks for fixing |
ViktorHofer
previously approved these changes
Feb 19, 2026
akoeplinger
previously approved these changes
Feb 20, 2026
Member
ahh so that's the secret to having green builds 😆 |
ViktorHofer
previously approved these changes
Feb 20, 2026
ec782ef
ellahathaway
previously approved these changes
Feb 20, 2026
Member
Author
|
Tests are passing now! |
ViktorHofer
approved these changes
Feb 21, 2026
1 task
akoeplinger
reviewed
Feb 22, 2026
| <ItemGroup Condition=" '$(HelixAccessToken)' != '' "> | ||
| <HelixTargetQueue Include="(AlmaLinux.9.Amd64)Ubuntu.2204.Amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:almalinux-9-helix-amd64"/> | ||
| <HelixTargetQueue Include="Windows.10.Amd64"/> | ||
| <HelixTargetQueue Include="Windows.11.Amd64"/> |
Member
There was a problem hiding this comment.
this one doesn't exist, it should be Windows.11.Amd64.Client: #16539
Member
Author
There was a problem hiding this comment.
Thanks for fixing.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16535
Remove Sdk="Microsoft.Build.NoTargets" from [UnitTests.proj]https://github.com/dotnet/arcade/blob/main/tests/UnitTests.proj). The Helix SDK already provides its own build infrastructure through its [NoBuild.targets]https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/Sdk/tools/NoBuild.targets). Including the NoTargets SDK is redundant and creates conflicts in import ordering.
This change aligns the project with the structure used by the XHarness test projects (which function correctly): a plain with explicit Helix SDK imports.
Fix the broken signing tests. Symbolic links are not supported by the signing infrastructure on Windows because creating or manipulating them requires elevated permissions. We don't want to promote/support symbolic links on Windows because of this.
Previously, the tests covering symbolic link scenarios (intended for Linux) were running on all platforms. These scenarios have been split into platform-specific tests. Additionally, the signing code has been updated to explicitly fail when encountering symbolic links on Windows.
The signing tests did surface a product issue with symbolic links in tarballs that was addressed.