-
Notifications
You must be signed in to change notification settings - Fork 383
Description
Problem
Commit e5101e573 ("[main] Source code updates from dotnet/dotnet") introduced a regression that silently broke Helix test submission. It made two changes simultaneously:
-
Added
Sdk="Microsoft.Build.NoTargets"toUnitTests.proj— This SDK imports its targets at the very end of the project, after the explicit Helix SDK imports. This meansDirectory.Build.targets→ Arcade'sTests.targetsdefines aTesttarget last, overriding the Helix SDK'sTesttarget (last definition wins in MSBuild). -
Refactored the Helix SDK's
Microsoft.DotNet.Helix.Sdk.targets— MovedTestDependsOn,BeforeTest,AfterTest, and theTesttarget definition from inline intoNoBuild.targets, which is conditionally skipped whenUsingMicrosoftNoTargetsSdk=true.
The result: Arcade's Tests.targets Test target (conditioned on IsUnitTestProject=true, which is false for this project) silently replaced the Helix SDK's Test target. The Test target became a no-op — no Helix jobs were ever submitted. The build reported success with zero tests run.