Don't sign F# projects during DotNetBuildSourceOnly.#15380
Merged
ViktorHofer merged 2 commits intodotnet:mainfrom Jan 7, 2025
Merged
Don't sign F# projects during DotNetBuildSourceOnly.#15380ViktorHofer merged 2 commits intodotnet:mainfrom
ViktorHofer merged 2 commits intodotnet:mainfrom
Conversation
ViktorHofer
reviewed
Jan 7, 2025
Comment on lines
+24
to
+30
| <!-- | ||
| Public signing (as performed under DotNetBuildSourceOnly) fails with the F# compiler. | ||
| https://github.com/dotnet/fsharp/issues/17451 | ||
| --> | ||
| <PropertyGroup Condition=" '$(DotNetBuildSourceOnly)' == 'true' and '$(MSBuildProjectExtension)' == '.fsproj' "> | ||
| <SignAssembly>false</SignAssembly> | ||
| </PropertyGroup> |
Member
There was a problem hiding this comment.
I think this needs to be set in Workaround.props as the property is later read here:
arcade/src/Microsoft.DotNet.Arcade.Sdk/tools/StrongName.targets
Lines 24 to 31 in ccae251
Member
Author
There was a problem hiding this comment.
Both work for fixing the issue I see in the runtime build. I've moved it to .props.
ViktorHofer
approved these changes
Jan 7, 2025
Member
Author
|
Thanks for the quick review @ViktorHofer! |
Member
|
Thanks for the fix @tmds :) |
tmds
added a commit
to tmds/arcade
that referenced
this pull request
Jan 16, 2025
…15380)" This change aimed to work around an issue in the F# compiler which doesn't permit public signing when the provided key is a full public/private key pair. It unintentionally resulted in the fsharp repository no longer being compiled with public signing, which causes product issues.
ViktorHofer
pushed a commit
that referenced
this pull request
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for dotnet/fsharp#17451.
@ViktorHofer ptal.