Revert "Don't sign F# projects during DotNetBuildSourceOnly. (#15380)"#15420
Merged
ViktorHofer merged 1 commit intodotnet:mainfrom Jan 16, 2025
Merged
Revert "Don't sign F# projects during DotNetBuildSourceOnly. (#15380)"#15420ViktorHofer merged 1 commit intodotnet:mainfrom
ViktorHofer merged 1 commit intodotnet:mainfrom
Conversation
…15380)" This change aimed to work around an issue in the F# compiler which doesn't permit public signing when the provided key is a full public/private key pair. It unintentionally resulted in the fsharp repository no longer being compiled with public signing, which causes product issues.
ViktorHofer
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aimed to work around an issue in the F# compiler which doesn't permit public signing when the provided key is a full public/private key pair.
It unintentionally resulted in the fsharp repository no longer being compiled with public signing, which causes product issues.
Fixes dotnet/runtime#111457.
@ViktorHofer ptal.