Fix incorrect conditions in eng/common/templates/job/job.yml#12471
Fix incorrect conditions in eng/common/templates/job/job.yml#12471ulisesh merged 2 commits intodotnet:mainfrom
Conversation
|
/azp run |
|
/azp run arcade-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
eng/common/templates/job/job.yml
Outdated
| - task: NuGetAuthenticate@0 | ||
|
|
||
| - ${{ if or(eq(parameters.artifacts.download, 'true'), ne(parameters.artifacts.download, '')) }}: | ||
| - ${{ if or(eq(parameters.artifacts.download, 'true'), eq(parameters.artifacts.download, '')) }}: |
There was a problem hiding this comment.
This makes "false" work, but still does the behavior in the case of a missing parameter. I strongly feel it should be just:
${{ if eq(parameters.artifacts.download, 'true') }}
There was a problem hiding this comment.
Changed, I'll update the issue
|
Thank you! |
|
On a second thought (after speaking with @MattGal) I think it was wrong to omit the second part of the condition. That is, it's probably not uncommon for consumers to not specify the "root" node (such as Lines 9 to 19 in 034aa38 This is why we need the second condition that checks for the empty string. |
…otnet#12471)" This reverts commit 0978c75.
Arcade issue #12393