-
Notifications
You must be signed in to change notification settings - Fork 382
Description
- This issue is blocking
- This issue is causing unreasonable pain
I believe the following conditions are incorrect:
arcade/eng/common/templates/job/job.yml
Line 174 in b40fa37
- ${{ if or(eq(parameters.artifacts.publish.artifacts, 'true'), ne(parameters.artifacts.publish.artifacts, '')) }}: arcade/eng/common/templates/job/job.yml
Line 195 in b40fa37
- ${{ if or(eq(parameters.artifacts.publish.logs, 'true'), ne(parameters.artifacts.publish.logs, '')) }}: arcade/eng/common/templates/job/job.yml
Line 137 in b40fa37
- ${{ if or(eq(parameters.artifacts.download, 'true'), ne(parameters.artifacts.download, '')) }}:
Essentially, they imply the following: "Run the task if (argument == 'true' OR argument != '')" which is always true unless the argument is not specified at all. And this is super weird and unexpected. E.g., the following configuration still runs the tasks:
jobs:
- template: /eng/common/templates/jobs/jobs.yml
parameters:
artifacts:
publish:
artifacts: false
logs: true
manifests: falseOnly after I have completely removed the entries, it worked as expected:
jobs:
- template: /eng/common/templates/jobs/jobs.yml
parameters:
artifacts:
publish:
- artifacts: false
logs: true
- manifests: falseI am pretty sure the conditions are meant to be the following: "Run the task if (argument == 'true' OR argument == '')" - i.e., run the task only if
- the argument isn't supplied - assume it's true, or
- the argument is true.
Release Note Category
- Feature changes/additions
- Bug fixes
- Internal Infrastructure Improvements

