[release/3.x] Fix native tools if/else logic#11212
Merged
jonfortescue merged 1 commit intodotnet:release/3.xfrom Oct 10, 2022
Merged
[release/3.x] Fix native tools if/else logic#11212jonfortescue merged 1 commit intodotnet:release/3.xfrom
jonfortescue merged 1 commit intodotnet:release/3.xfrom
Conversation
MattGal
approved these changes
Oct 10, 2022
jonfortescue
added a commit
to dotnet/wpf
that referenced
this pull request
Oct 10, 2022
Contributor
Author
|
Fix tested here and seems to be working, merging. |
dotnet-maestro bot
added a commit
to dotnet/wpf
that referenced
this pull request
Oct 12, 2022
[release/3.1] Update dependencies from dotnet/arcade - Fixup curly braces to test dotnet/arcade#11212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The if/else logic was off by one curly brace (and missing a bit of logic for local dev). This bring it into parity with the main branch and will fix the issue seen in dotnet/wpf#7166.
Customer Impact
Unblocks arcade updates on release/3.x branch for customers using native tools.
Regression
No.
Risk
None.
Workarounds
No.