Skip to content

[release/3.1] Update dependencies from dotnet/arcade#7166

Merged
dotnet-maestro[bot] merged 2 commits intorelease/3.1from
darc-release/3.1-21e45b53-d12d-4494-b4ac-b549874af64d
Oct 12, 2022
Merged

[release/3.1] Update dependencies from dotnet/arcade#7166
dotnet-maestro[bot] merged 2 commits intorelease/3.1from
darc-release/3.1-21e45b53-d12d-4494-b4ac-b549874af64d

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 6, 2022 •
edited by ghost
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: f6560d32-4c6b-4ed3-5c71-08d72a4d3f20
  • Build: 20221005.4
  • Date Produced: October 5, 2022 7:38:53 PM UTC
  • Commit: ce5a281156dfae3c050e63c1f288b6a488e978fe
  • Branch: refs/heads/release/3.x
  • Updates to .NET SDKs:
    • Updates tools.dotnet to 3.1.423
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20221…
9b1a2af 
…005.4

Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 1.0.0-beta.22314.5 -> To Version 1.0.0-beta.22505.4
ghost
ghost approved these changes Oct 6, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Oct 6, 2022
@ghost ghost requested review from dipeshmsft and singhashish-wpf October 6, 2022 14:28
@pchaurasia14
Copy link
Contributor

pchaurasia14 commented Oct 10, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 10, 2022

No pipelines are associated with this pull request.

@singhashish-wpf
Copy link
Contributor

singhashish-wpf commented Oct 10, 2022

@dotnet/dnceng-admin @mmitche Does the repo need some updates? It seems that the intellisense xml directory is not generated in this build using and the error is being reported due to that.

@mmitche
Copy link
Member

mmitche commented Oct 10, 2022 •
edited
Loading

@dotnet/dnceng-admin @mmitche Does the repo need some updates? It seems that the intellisense xml directory is not generated in this build using and the error is being reported due to that.

I'm unsure what the issue is here. The changes in arcade are pretty benign.

@mmitche
Copy link
Member

mmitche commented Oct 10, 2022

https://github.com/dotnet/wpf/pull/7166/files#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bfR21

@mmitche
Copy link
Member

mmitche commented Oct 10, 2022

@jonfortescue THis looks like a native tools issue. Can you take a look?

@MattGal
Copy link
Member

MattGal commented Oct 10, 2022

Looks like fallout from @jonfortescue 's recent work, he's online now and will take point; probably just need to turn this feature off via a flag.

@jonfortescue
Copy link
Contributor

jonfortescue commented Oct 10, 2022 •
edited
Loading

Taking a look. At first glance though, wpf doesn't seem to be using the new native tools stuff (although they probably should), so I'm not immediately sure it's related. Either way, investigating.

Edit: unless it's a bug with the new if/then logic, which is of course possible.

@jonfortescue
Copy link
Contributor

jonfortescue commented Oct 10, 2022

Looks like there's a bug with the if/else logic but only on the release/3.1 branch. Pushing a fix shortly.

@jonfortescue jonfortescue mentioned this pull request Oct 10, 2022
Merged
@jonfortescue
Copy link
Contributor

jonfortescue commented Oct 10, 2022

New failures are unrelated to native tools, it looks like. Fix seems to have worked.

@singhashish-wpf
Copy link
Contributor

singhashish-wpf commented Oct 12, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 12, 2022

No pipelines are associated with this pull request.

@dotnet-maestro dotnet-maestro bot merged commit dc62591 into release/3.1 Oct 12, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-release/3.1-21e45b53-d12d-4494-b4ac-b549874af64d branch October 12, 2022 09:14
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pchaurasia14 @singhashish-wpf @mmitche @MattGal @jonfortescue