Fix for msbuild server - InstallDotNetCore task redirects its outputs #10629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redirect-InstallDotNetCore-process-stds
Member
|
Validated using https://dev.azure.com/dnceng/public/_build/results?buildId=1976521&view=logs&j=b4b82daf-8483-52c8-7957-6550d3491704 , signing off. |
MattGal
approved these changes
Aug 30, 2022
2 tasks
MattGal
added a commit
to MattGal/arcade
that referenced
this pull request
Sep 6, 2022
…dotnet#10629) * Redirect InstallDotNetCore child processes stdout and stderr
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
MSBuild server runs as long live process, similar to VBCSCompiler, as oppose to formal short living console application.
Custom Tasks which execute child process from might be broken, as output from child processes started from detached parent process are not redirected to parent process.
This PR addresses issue: dotnet/msbuild#7913
Unblocks
Changes made
Redirects outputs of child process running install-script.sh which makes it agnostics if run from process attached to terminal or form detached process such as msbuild server or worker node.
NOTE
This is second try as the 1st one causes failing tests in arcade-validation.
See: dotnet/arcade-validation#3323 and #10585