Fix for msbuild server - InstallDotNetCore task outputs list of required dotnets to be installed #10585
Conversation
…ed and target does Exec it.
|
I am publishing a version of this to "General Testing" to prove it unblocks ASP.NET, after which I will approve. |
|
This Draft PR uses a "real" published copy of this change and will demonstrate if the problem is fully fixed: dotnet/aspnetcore#43555 |
src/Microsoft.DotNet.Arcade.Sdk/tools/InstallDotNetCore.targets
Outdated
Show resolved
Hide resolved
|
I made the suggested change in an internal branch and am publishing another general testing one to see if this works. |
Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>
MattGal
left a comment
There was a problem hiding this comment.
I personally published these changes as BAR Build ID 146476 and verified they unblock the source-build for ASP.NET Core
|
dotnet/aspnetcore#43568 tries the latest version of the SDK from their branch + this arcade change and nothing else, stacked on Main. |
|
All linked builds got past the install dotnet stage and issues were around updating to RC2 SDK, so I am going to merge this. |
…of required dotnets to be installed (dotnet#10585)" This reverts commit b084bcc.
Context
MSBuild server runs as long live process, similar to VBCSCompiler, as oppose to formal short living console application.
Custom Tasks which execute child process from might be broken, as output from child processes started from detached parent process are not redirected to parent process.
This PR addresses issue: dotnet/msbuild#7913
Unblocks