-
Notifications
You must be signed in to change notification settings - Fork 382
Comparing changes
Open a pull request
base repository: dotnet/arcade
base: c453dfe
head repository: dotnet/arcade
compare: 96d8be7
- 18 commits
- 21 files changed
- 10 contributors
Commits on Feb 6, 2023
-
[main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotn…
…et/sourcelink (#12404) [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotnet/sourcelink
Configuration menu - View commit details
-
Copy full SHA for 77f2a22 - Browse repository at this point
Copy the full SHA 77f2a22View commit details -
Update dependencies from https://github.com/dotnet/xharness build 202…
…30202.1 (#12443) [main] Update dependencies from dotnet/xharness
Configuration menu - View commit details
-
Copy full SHA for db243ca - Browse repository at this point
Copy the full SHA db243caView commit details -
Update dependencies from https://github.com/dotnet/sourcelink build 2…
…0230205.1 (#12446) [main] Update dependencies from dotnet/sourcelink
Configuration menu - View commit details
-
Copy full SHA for ef45202 - Browse repository at this point
Copy the full SHA ef45202View commit details -
Fix project build exclusion logic in the face of static graph (#12425)
* Fix project build exclusion logic in the face of static graph While working on filtering, I discovered that static graph and target filtering do not play nicely together. After some help from the msbuild team, the problem was identified. Arcade typically uses a series of empty targets that override standard targets (or its own) to avoid executing a project build or restore. Static graph, however, uses the existence of the _IsProjectRestoreSupported target, rather than its return value to determine whether restore is supported. This means that any excluded project still gets restored in static graph mode. The fix (or workaround, depending on how you look at it) for this is to set the NuGetRestoreTargets file to an empty stub early enough in the build (in the BeforeCommonTargets hook) so that this target is never loaded at all. This requires determining whether a build will be skipped earlier than we do today, in BeforeCommonTargets rather than in Sdk.targets. The code has been refactored so that we determine whether a build should be skipped in ExcludeFromBuild.BeforeCommonTargets.targets, which is imported in the BeforeCommonTargets files. I've also moved the import of these files earlier so that in cases where the BeforeCommonTargets SDK hook is **not** used (see #2676), we will still compute the exclusion properties early enough to import "Empty.targets". In that case, we also create the target.
Configuration menu - View commit details
-
Copy full SHA for 02980a6 - Browse repository at this point
Copy the full SHA 02980a6View commit details
Commits on Feb 7, 2023
-
[main] Update dependencies from dotnet/arcade dotnet/sourcelink (#12463)
[main] Update dependencies from dotnet/arcade dotnet/sourcelink
Configuration menu - View commit details
-
Copy full SHA for 5d1df73 - Browse repository at this point
Copy the full SHA 5d1df73View commit details -
Update dependencies from https://github.com/dotnet/roslyn build 20230…
…201.20 (#12444) [main] Update dependencies from dotnet/roslyn
Configuration menu - View commit details
-
Copy full SHA for b31c446 - Browse repository at this point
Copy the full SHA b31c446View commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0978c75 - Browse repository at this point
Copy the full SHA 0978c75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 173c8fb - Browse repository at this point
Copy the full SHA 173c8fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad760ca - Browse repository at this point
Copy the full SHA ad760caView commit details
Commits on Feb 9, 2023
-
[main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotn…
…et/sourcelink (#12490) [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotnet/sourcelink
Configuration menu - View commit details
-
Copy full SHA for 8c64aef - Browse repository at this point
Copy the full SHA 8c64aefView commit details -
Publish library symbols to dotnetbuilds (#12511)
* Publish library symbols to dotnetbuilds * Remove blazor
Configuration menu - View commit details
-
Copy full SHA for 179e63f - Browse repository at this point
Copy the full SHA 179e63fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfb2f58 - Browse repository at this point
Copy the full SHA bfb2f58View commit details -
Update test retries documentation (#12387)
* Update test retries documentation * Add multiple rules example: * Update src/Microsoft.DotNet.Helix/Sdk/Readme.md Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com> * Update src/Microsoft.DotNet.Helix/Sdk/Readme.md Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com> --------- Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for aba5d4f - Browse repository at this point
Copy the full SHA aba5d4fView commit details
Commits on Feb 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b888df1 - Browse repository at this point
Copy the full SHA b888df1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00efb56 - Browse repository at this point
Copy the full SHA 00efb56View commit details -
[main] Update dependencies from dotnet/arcade dotnet/sourcelink (#12532)
[main] Update dependencies from dotnet/arcade dotnet/sourcelink
Configuration menu - View commit details
-
Copy full SHA for 91b951e - Browse repository at this point
Copy the full SHA 91b951eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73d4f5b - Browse repository at this point
Copy the full SHA 73d4f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d8be7 - Browse repository at this point
Copy the full SHA 96d8be7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c453dfe...96d8be7