Skip to content

Publish library symbols to dotnetbuilds#12511

Merged
mmitche merged 1 commit intodotnet:mainfrom
mmitche:publish-library-syms-to-staging
Feb 9, 2023
Merged

Publish library symbols to dotnetbuilds#12511
mmitche merged 1 commit intodotnet:mainfrom
mmitche:publish-library-syms-to-staging

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Feb 9, 2023

Not sure why this didn't switch over to dotnetbuilds a ways back.

@mmitche mmitche requested review from epananth and riarenas February 9, 2023 15:33
(InstallersAndSymbols, FeedForInstallers),
(TargetFeedContentType.Checksum, FeedForChecksums),
(InstallersAndSymbols, FeedStagingForInstallers),
(TargetFeedContentType.Checksum, FeedStagingForChecksums),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change LN 150 to use this one? and the internal feeds to use the internal equivalent? Looks like we didn't change any3.1 ones, but I can't find whether that was intentional.

Also should we change the .NET 5 ones, or are those dead dead? I never remember.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.1 and 5.0 never got the updates to pull from dotnetbuilds. I looked at the blazor lines and it turns out the variables aren't even referenced, so I just deleted them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing the 3.1 feeds isn't it? Maybe this change is supposed to go here? https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Feed/src/model/PublishingConstants.cs#L955

@mmitche mmitche enabled auto-merge (squash) February 9, 2023 16:23
@mmitche mmitche force-pushed the publish-library-syms-to-staging branch from fa20d73 to 4cd9556 Compare February 9, 2023 16:49
@mmitche
Copy link
Member Author

mmitche commented Feb 9, 2023

Okay better now.

@mmitche mmitche merged commit 179e63f into dotnet:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants