Split and deprecate AbstractQuery#useResultCache() by someniatko · Pull Request #7701 · doctrine/orm

someniatko · 2019-05-07T20:27:10Z

Split useResultCache($boolFlag, ...) into enableResultCache() and disableResutCache().

To create tests for enableResultCache() and disableResultCache(), useResultCache()'s tests were copy-pasted, but I think that's fine.

This is proper PR, original one is #7213

greg0ire · 2019-05-07T20:45:07Z

IMO you should fixup the first commit into the new one. Do you know how to do this without creating a new PR? Otherwise I can help.

someniatko · 2019-05-08T07:17:04Z

@greg0ire yes. Last time i recreated the PR because a) initial branch was wrong (i committed directly to 2.7 of my fork), and b) interactive rebase rendered in merge conflicts for some reason, even if i tried to rebase without changing anything in commits order. It was easier to just start over and cherry-pick.

Okay, will rebase and force push now.

someniatko · 2019-05-23T14:42:00Z

@greg0ire ping. I noticed you've put "Deprecation" label and "2.7.0" milestone to the previous PR, #7213. I think you should at least do the same for this one.

tests/Doctrine/Tests/ORM/Functional/ResultCacheTest.php

greg0ire

It reads far better now, great work!

greg0ire · 2019-06-22T13:58:27Z

Are there no docs that need to be updated?

jwage · 2019-06-22T16:36:23Z

The deprecation should be added to the UPGRADE.md document too?

SenseException

useResultCache appears in https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/caching.html#result-cache and needs to be mentioned/adapted for 2.7.

lib/Doctrine/ORM/AbstractQuery.php

someniatko · 2019-06-27T09:40:24Z

Got it, will add the requested changes to documentation and UPGRADE.md

someniatko · 2019-07-03T12:51:14Z

Made the requested changes to documentation. Also i'd like to reject @SenseException 's suggestion for the reasons described above.

SenseException

Looks good to me.

Will those changes be merged or picked into master or is another PR for master needed?

someniatko · 2019-07-23T07:09:09Z

@SenseException there is a pull request to master: #7214
It will need some work as well, like updating documentation. However I'd wait for this pull request to be merged before working on master's one.

lcobucci

@someniatko thanks!

@lcobucci

…gin-master v2.7.0 [![Build Status](https://travis-ci.org/doctrine/orm.svg?branch=v2.7.0)](https://travis-ci.org/doctrine/orm) This release solves Symfony 5.0 compatibility issues, some small improvements, and adds various deprecation notices. Please read carefully the [upgrade to 2.7 notes](https://github.com/doctrine/orm/blob/2.7/UPGRADE.md#upgrade-to-27) to know more about the reasons and how to fix the deprecation messages. --- - Total issues resolved: **1** - Total pull requests resolved: **15** - Total contributors: **10** Deprecation ----------- - [7911: Be explicit about which Doctrine package in message](doctrine#7911) thanks to @lcobucci - [7909: Add deprecation messages](doctrine#7909) thanks to @lcobucci - [7901: Add deprecation warnings for 2.7.x](doctrine#7901) thanks to @lcobucci - [7701: Split and deprecate AbstractQuery#useResultCache()](doctrine#7701) thanks to @someniatko CI -- - [7904: Make sure composer files are valid](doctrine#7904) thanks to @greg0ire - [7600: &doctrine#91;2.7&doctrine#93; CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#7600) thanks to @Majkl578 Improvement ----------- - [7876: Fix compat of commands with Symfony 5](doctrine#7876) thanks to @nicolas-grekas - [7829: Skip Paginator LIMIT subquery and WHERE IN if query do not have LIMIT](doctrine#7829) thanks to @Seb33300 - [7723: Allow Symfony 5.0](doctrine#7723) thanks to @nicolas-grekas - [7710: Prettified arrays in tool command orm:mapping:describe](doctrine#7710) thanks to @rtek - [7340: Fix config template for PHPUnit >= 7.2](doctrine#7340) thanks to @guilliamxavier BC Break,Improvement -------------------- - [7863: Paginator: Skip limit subquery if not required](doctrine#7863) thanks to @Seb33300 Documentation ------------- - [7382: Update homepage](doctrine#7382) thanks to @Majkl578 Bug --- - [7326: Cherry-pick doctrine#7307 to fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common](doctrine#7326) thanks to @nicolas-grekas - [7079: Fix getJoinTableName for sqlite with schema attribute](doctrine#7079) thanks to @mairo744 BC Break,Deprecation,Improvement -------------------------------- - [6803: Deprecation of EntityManager copy method](doctrine#6803) thanks to @SenseException

someniatko changed the base branch from master to 2.7 May 7, 2019 20:27

someniatko mentioned this pull request May 7, 2019

Split and deprecate AbstractQuery#useResultCache() #7213

Closed

someniatko force-pushed the deprecate-use-result-cache branch from 5e891fc to 0abffd1 Compare May 8, 2019 07:26

greg0ire added the Deprecation label May 23, 2019

greg0ire reviewed May 23, 2019

View reviewed changes

tests/Doctrine/Tests/ORM/Functional/ResultCacheTest.php Outdated Show resolved Hide resolved

someniatko force-pushed the deprecate-use-result-cache branch from df22e8a to 67a62ae Compare May 25, 2019 17:18

greg0ire previously approved these changes May 25, 2019

View reviewed changes

Ocramius assigned greg0ire May 27, 2019

Ocramius added this to the 2.7.0 milestone May 27, 2019

greg0ire requested a review from a team June 22, 2019 13:57

SenseException requested changes Jun 24, 2019

View reviewed changes

lib/Doctrine/ORM/AbstractQuery.php Outdated Show resolved Hide resolved

someniatko dismissed greg0ire’s stale review via 9c88aa8 July 3, 2019 12:50

greg0ire requested a review from SenseException July 3, 2019 18:56

SenseException previously approved these changes Jul 4, 2019

View reviewed changes

lcobucci force-pushed the 2.7 branch from 9e73672 to 40f2406 Compare September 23, 2019 09:29

lcobucci force-pushed the 2.7 branch from 40f2406 to d9c30e3 Compare October 23, 2019 13:59

greg0ire dismissed SenseException’s stale review via fe7c61e November 14, 2019 21:10

greg0ire force-pushed the deprecate-use-result-cache branch from 9c88aa8 to fe7c61e Compare November 14, 2019 21:10

someniatko added 2 commits November 16, 2019 01:59

Split and deprecate AbstractQuery#useResultCache()

7bcbad0

Make ResultCacheTest tests slightly more logical

e8f265d

lcobucci force-pushed the deprecate-use-result-cache branch from fe7c61e to e8f265d Compare November 16, 2019 01:00

lcobucci approved these changes Nov 16, 2019

View reviewed changes

lcobucci merged commit 977985f into doctrine:2.7 Nov 16, 2019

greg0ire mentioned this pull request Nov 29, 2019

Do not deprecate useResultCache #7933

Closed

derrabus mentioned this pull request May 11, 2022

Split and remove AbstractQuery#useResultCache() #7214

Closed

Conversation

someniatko commented May 7, 2019

Uh oh!

greg0ire commented May 7, 2019

Uh oh!

someniatko commented May 8, 2019

Uh oh!

someniatko commented May 23, 2019

Uh oh!

Uh oh!

greg0ire left a comment

Choose a reason for hiding this comment

Uh oh!

greg0ire commented Jun 22, 2019

Uh oh!

jwage commented Jun 22, 2019

Uh oh!

SenseException left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

someniatko commented Jun 27, 2019

Uh oh!

someniatko commented Jul 3, 2019

Uh oh!

SenseException left a comment

Choose a reason for hiding this comment

Uh oh!

someniatko commented Jul 23, 2019

Uh oh!

lcobucci left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants