Split and deprecate AbstractQuery#useResultCache()#7213
Closed
someniatko wants to merge 0 commit intodoctrine:2.7from
Closed
Split and deprecate AbstractQuery#useResultCache()#7213someniatko wants to merge 0 commit intodoctrine:2.7from
someniatko wants to merge 0 commit intodoctrine:2.7from
Conversation
greg0ire
requested changes
May 3, 2019
lib/Doctrine/ORM/AbstractQuery.php
Outdated
| * | ||
| * @return static This query instance. | ||
| */ | ||
| public function enableResultCache($lifetime = null, $resultCacheId = null) |
Member
There was a problem hiding this comment.
Suggested change
| public function enableResultCache($lifetime = null, $resultCacheId = null) | |
| public function enableResultCache(?int $lifetime = null, ?string $resultCacheId = null): self |
lib/Doctrine/ORM/AbstractQuery.php
Outdated
| * | ||
| * @return static This query instance. | ||
| */ | ||
| public function disableResultCache() |
Member
There was a problem hiding this comment.
Suggested change
| public function disableResultCache() | |
| public function disableResultCache(): self |
Member
|
You will probably need to rebase as your branch contains commits that you did not author. |
Contributor
Author
|
okay, will work on it later today |
Contributor
Author
|
created new PR: #7701 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
useResultCache($boolFlag, ...)intoenableResultCache()anddisableResutCache().To create tests for
enableResultCache()anddisableResultCache(),useResultCache()'s tests were copy-pasted, but I think that's fine.