Merged
Conversation
Member
derrabus
commented
Jan 15, 2022
| Q | A |
|---|---|
| Type | improvement |
| BC Break | no |
| Fixed issues | N/A |
Merged
morozov
reviewed
Jan 16, 2022
| paths: | ||
| - lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php | ||
|
|
||
| # This is a new requirement for PHP7's oci8 extension that prevents bound values from being garbage collected. |
Member
There was a problem hiding this comment.
IIRC, I checked it recently and it's not true. Why isn't this change necessary in #5179?
Member
Author
There was a problem hiding this comment.
I don't know enough about Oracle and its PHP drivers to answer this question. PHPStan emitted this error, I looked up the code that caused it and found this comment there, so I just copied it over to this file.
Member
There was a problem hiding this comment.
Indeed, this code doesn't exist in 3.2.x as of #4957:
Additionally, it removes the
$boundValuesproperty. It might be necessary in the early PHP 7 days but doesn't seem necessary now (besides PHP 7.4 on CI, tested locally with PHP 7.3.32).
Keeping this error suppressed in 2.13.x looks right.
morozov
approved these changes
Jan 16, 2022
SenseException
approved these changes
Jan 16, 2022
tzkoshi
pushed a commit
to tzkoshi/dbal
that referenced
this pull request
Mar 16, 2022
Release [2.13.8](https://github.com/doctrine/dbal/milestone/104) 2.13.8 ====== - Total issues resolved: **1** - Total pull requests resolved: **9** - Total contributors: **3** CI,SQL Server ------------- - [5303: Run workflow on AppVeyor only if certain files changed](doctrine#5303) thanks to @morozov Dependencies,Static Analysis ---------------------------- - [5300: Psalm 4.22.0, PHPUnit 9.5.16](doctrine#5300) thanks to @derrabus Bug,PHP,mysqli -------------- - [5296: Fix PHP 8.1 deprecation on `mysqli::real&doctrine#95;connect()` calls](doctrine#5296) thanks to @iammati Error Handling,Static Analysis,mysqli ------------------------------------- - [5269: Run static analysis jobs on PHP 8.1](doctrine#5269) thanks to @morozov Static Analysis --------------- - [5262: PHPStan 1.4.6, Psalm 4.20.0, PHPUnit 9.5.13](doctrine#5262) thanks to @derrabus - [5178: PHPStan 1.4.0](doctrine#5178) thanks to @derrabus CI -- - [5238: Run PHP 7.4 on AppVeyor](doctrine#5238) thanks to @derrabus Documentation ------------- - [5187: Update README for release 3.3](doctrine#5187) thanks to @derrabus Connections,Reserved Keywords,Static Analysis --------------------------------------------- - [5166: Enforce consistent constructor in dynamically instantiated classes](doctrine#5166) thanks to @morozov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.