Skip to content

Enforce consistent constructor in dynamically instantiated classes#5166

Merged
morozov merged 1 commit intodoctrine:2.13.xfrom
morozov:issues/4511
Jan 6, 2022
Merged

Enforce consistent constructor in dynamically instantiated classes#5166
morozov merged 1 commit intodoctrine:2.13.xfrom
morozov:issues/4511

Conversation

@morozov
Copy link
Copy Markdown
Member

@morozov morozov commented Jan 6, 2022

Q A
Type improvement
BC Break no

Closes #4511.

@morozov morozov added this to the 2.13.8 milestone Jan 6, 2022
@morozov morozov linked an issue Jan 6, 2022 that may be closed by this pull request
/**
* Abstract interface for a SQL reserved keyword dictionary.
*
* @psalm-consistent-constructor
Copy link
Copy Markdown
Member Author

@morozov morozov Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed in 4.0.x thanks to #4583.

@morozov morozov requested review from derrabus and greg0ire January 6, 2022 17:51
@morozov morozov merged commit 4832932 into doctrine:2.13.x Jan 6, 2022
@morozov morozov deleted the issues/4511 branch February 13, 2022 07:52
tzkoshi pushed a commit to tzkoshi/dbal that referenced this pull request Mar 16, 2022
Release [2.13.8](https://github.com/doctrine/dbal/milestone/104)

2.13.8
======

- Total issues resolved: **1**
- Total pull requests resolved: **9**
- Total contributors: **3**

CI,SQL Server
-------------

 - [5303: Run workflow on AppVeyor only if certain files changed](doctrine#5303) thanks to @morozov

Dependencies,Static Analysis
----------------------------

 - [5300: Psalm 4.22.0, PHPUnit 9.5.16](doctrine#5300) thanks to @derrabus

Bug,PHP,mysqli
--------------

 - [5296: Fix PHP 8.1 deprecation on `mysqli::real&doctrine#95;connect()` calls](doctrine#5296) thanks to @iammati

Error Handling,Static Analysis,mysqli
-------------------------------------

 - [5269: Run static analysis jobs on PHP 8.1](doctrine#5269) thanks to @morozov

Static Analysis
---------------

 - [5262: PHPStan 1.4.6, Psalm 4.20.0, PHPUnit 9.5.13](doctrine#5262) thanks to @derrabus
 - [5178: PHPStan 1.4.0](doctrine#5178) thanks to @derrabus

CI
--

 - [5238: Run PHP 7.4 on AppVeyor](doctrine#5238) thanks to @derrabus

Documentation
-------------

 - [5187: Update README for release 3.3](doctrine#5187) thanks to @derrabus

Connections,Reserved Keywords,Static Analysis
---------------------------------------------

 - [5166: Enforce consistent constructor in dynamically instantiated classes](doctrine#5166) thanks to @morozov
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signature of wrapper Connection constructor is not enforced

2 participants