Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Allow Symfony 5.0#158

Merged
alcaeus merged 1 commit intodoctrine:masterfrom
nicolas-grekas:sf5
May 28, 2019
Merged

Allow Symfony 5.0#158
alcaeus merged 1 commit intodoctrine:masterfrom
nicolas-grekas:sf5

Conversation

@nicolas-grekas
Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas commented May 28, 2019

Until this is completely removed from DoctrineBundle, let's allow the Symfony 5.0 CI to pass.
Sibling of doctrine/DoctrineBundle#975

@jwage jwage requested a review from alcaeus May 28, 2019 14:39
@nicolas-grekas nicolas-grekas mentioned this pull request May 28, 2019
Merged
5 tasks
@alcaeus
Copy link
Copy Markdown
Member

alcaeus commented May 28, 2019

Merging this PR until we have removed the dependency on this bundle from DoctrineBundle. The decision to deprecate this bundle and not add support for Symfony 5 (as indicated in #156) still stands: this PR will be reverted once we've removed the dependency mentioned above.

@alcaeus alcaeus merged commit cfc1ce9 into doctrine:master May 28, 2019
@alcaeus alcaeus self-assigned this May 28, 2019
@nicolas-grekas nicolas-grekas deleted the sf5 branch May 28, 2019 15:11
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request May 28, 2019
@nicolas-grekas
minor symfony#31655 Bump Symfony 5.0 to PHP 7.2 (nicolas-grekas)
a5fb206 
This PR was merged into the 5.0-dev branch.

Discussion
----------

Bump Symfony 5.0 to PHP 7.2

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Not ready yet.

7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.)

7.2.9 because of https://tracker.debian.org/pkg/php7.2

Needs:
- [x] symfony/security-acl#48
- [x] doctrine/orm#7723
- [x] doctrine/DoctrineBundle#975
- [x] doctrine/DoctrineCacheBundle#158
- [x] symfony#31657

Commits
-------

d94d9d7 Bump Symfony 5.0 to PHP 7.2
@mvorisek
Copy link
Copy Markdown

mvorisek commented Mar 9, 2020

Can a new tagged release be made to reflect this merged PR?

@alcaeus
Copy link
Copy Markdown
Member

alcaeus commented Mar 9, 2020

No:

Merging this PR until we have removed the dependency on this bundle from DoctrineBundle. The decision to deprecate this bundle and not add support for Symfony 5 (as indicated in #156) still stands: this PR will be reverted once we've removed the dependency mentioned above.

See also #161.

@stof
Copy link
Copy Markdown
Member

stof commented Mar 9, 2020

Well, we should tag a release, otherwise DoctrineBundle cannot be installed in a Symfony 5 project without people adding a root requirement on DoctrineCacheBundle to whitelist its dev version, which will actually make the deprecation harder.
That's either that, or removing the dependency in DoctrineBundle must be given a very high priority.

@alcaeus
Copy link
Copy Markdown
Member

alcaeus commented Mar 9, 2020

That's either that, or removing the dependency in DoctrineBundle must be given a very high priority.

The dependency has been removed as of the 2.0 release: doctrine/DoctrineBundle#1029

@stof
Copy link
Copy Markdown
Member

stof commented Mar 9, 2020

Oh, I forgot that. Then it is fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alcaeus alcaeus Awaiting requested review from alcaeus

Assignees

@alcaeus alcaeus

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas @alcaeus @mvorisek @stof