This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Mark root configuration node as deprecated#161
Merged
alcaeus merged 6 commits intodoctrine:masterfrom Nov 29, 2019
Merged
Conversation
stof
reviewed
Nov 29, 2019
SenseException
approved these changes
Nov 29, 2019
Member
SenseException
left a comment
There was a problem hiding this comment.
Actually, this PR is okay, but do we need to remove the installation guide from the readme?
dmaicher
approved these changes
Nov 29, 2019
Member
Author
I wouldn’t recommend people install this bundle in a new project, which is why I’ve removed the instructions. I’d rather add uninstall instructions instead 😉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This marks the root configuration node as deprecated, hopefully getting people to replace their
doctrine_cacheconfig with something else. This bundle will not be adapted for Symfony 5 and will be retired after the EOL of Symfony 4.4 or once usage has gone down enough.Note that build failures are already present on master and IMO aren't worth it spending time on fixing them. Contributions are welcome if people would rather have a stable build.