added simple support for propagation in bind mounts#3164
Closed
jannefleischer wants to merge 17 commits intodocker:mainfrom
Closed
added simple support for propagation in bind mounts#3164jannefleischer wants to merge 17 commits intodocker:mainfrom
jannefleischer wants to merge 17 commits intodocker:mainfrom
Conversation
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
milas
suggested changes
Aug 14, 2023
Contributor
milas
left a comment
There was a problem hiding this comment.
Ah, spoke too soon. The flake8 lint job is failing. If you fix the issues there, I'll get this merged
Signed-off-by: Janne Jakob Fleischer <janne.fleischer@ils-forschung.de>
Manually merging docker#3126.
milas
added a commit
that referenced
this pull request
Aug 15, 2023
Manually merging #3164. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Contributor
|
Thanks for the PR and fixes - this is merged via 0f0b20a. (Apologies for any noise/confusion, I had to rebase and do some Git shenanigans 😓) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For autofs-support in Jupyterhub I needed propagation support in bind mounts. So I added this.
Though I don't know if you want it in here, due to the lack of Docker Desktop support.