Switch linting to ruff, use f-strings, fix lint errors and possible bugs#3126
Merged
milas merged 13 commits intodocker:mainfrom Aug 15, 2023
Merged
Switch linting to ruff, use f-strings, fix lint errors and possible bugs#3126milas merged 13 commits intodocker:mainfrom
milas merged 13 commits intodocker:mainfrom
Conversation
7f6a4d5 to
15bd6e0
Compare
68a2d51 to
6fb7e6f
Compare
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
milas
approved these changes
Aug 15, 2023
Contributor
milas
left a comment
There was a problem hiding this comment.
Thanks! I appreciate how methodical you were here.
milas
added a commit
to milas/docker-py
that referenced
this pull request
Aug 15, 2023
Manually merging docker#3126.
Contributor
|
FYI the integration test failure was because the test was broken [before this PR] - it was missing (Also apologies for noise to anyone watching this repo, it appears my Git pushes might have caused a bunch of notification emails 😬) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a bit on the big side, but it should be pretty straightforward to review commit by commit. A net line reduction
too!
It:
.formatand%string formatting with the more succinct and performant f-strings wherever possible (this was half powered byflynt, half manual work)flake8linter with the much faster, more capable ruff linterruff. See each commit's message for details.