[master] update Compose to v2.3.4#652
Conversation
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
|
Hmmm.. does kubernetes now require CGO or something? Or are they no longer compatible with go1.16? |
|
CGO, not JSON (lol.. in two chats at the same time) 😂 |
|
Guessing this could be related; looks like they copy Golang's code into their own repository; kubernetes-sigs/json@80fe866 Dependency was added as part of docker/compose#9254 (not 100% sure where buildx requires/uses kubernetes in the client side) @crazy-max probably knows |
|
So that depends on Go 1.17 indeed, which introduced the |
|
As discussed with @thaJeztah you should have the same replaces in compose: https://github.com/docker/buildx/blob/1ca30a58c2f25a7f72a2fdb5d62e82bf1e2fa37c/go.mod#L62-L64. See also docker/buildx#948 |
|
Opened docker/compose#9317 to pin the dependencies (but will need a new release after that) |
|
We updated master to go1.17, and I kicked CI for this PR If we want to ship an updated version of compose before docker 22.xx is released, we need to have docker/compose#9317 merged and a new version of compose (this PR on master we can merge if CI goes green) |
Signed-off-by: Guillaume Lours guillaume.lours@docker.com