go.mod: pin k8s version to fix build on go1.16, and update buildx to v0.8.1#9317
Merged
go.mod: pin k8s version to fix build on go1.16, and update buildx to v0.8.1#9317
Conversation
Buildx uses replace rules to pin these dependencies to the version that's used in buildkit. Newer versions of these dependencies are incompatible with some go versions, and we do not need the newer versions for where it's used. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Fix possible panic on handling build context scanning errors Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Mar 25, 2022
Comment on lines
-2284
to
-2285
| sigs.k8s.io/json v0.0.0-20211020170558-c049b76a60c6 h1:fD1pz4yfdADVNfFmcP2aBEtudwUQ1AlLnRBALr33v3s= | ||
| sigs.k8s.io/json v0.0.0-20211020170558-c049b76a60c6/go.mod h1:p4QtZmO4uMYipTQNzagwnNoseA6OxSUutVw05NhYDRs= |
Member
Author
There was a problem hiding this comment.
This is the dependency that broke the build; it's a fork of Golang's json package, but "case-sensitive", and it's depending on some features that are not available in go1.16 (which is still in use in the docker 20.10 release pipeline)
Member
Author
ndeloof
approved these changes
Mar 28, 2022
Contributor
ndeloof
left a comment
There was a problem hiding this comment.
LGTM.
We should adopt same approach proposed on docker/buildx#840 so that we don't get such side effect as packaging tries to build from source with a distinct runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.mod: pin k8s dependencies to the same version as in buildx
Buildx uses replace rules to pin these dependencies to the version
that's used in buildkit. Newer versions of these dependencies are
incompatible with some go versions, and we do not need the newer
versions for where it's used.
go.mod: github.com/docker/buildx v0.8.1
Fix possible panic on handling build context scanning errors
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did