vendor: update buildkit to 2f99651#948
Merged
AkihiroSuda merged 1 commit intodocker:masterfrom Feb 10, 2022
Merged
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
11feb20 to
307c94e
Compare
tonistiigi
approved these changes
Feb 10, 2022
AkihiroSuda
approved these changes
Feb 10, 2022
AkihiroSuda
reviewed
Mar 14, 2023
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp => github.com/tonistiigi/opentelemetry-go-contrib/instrumentation/net/http/otelhttp v0.0.0-20211026174723-2f82a1e0c997 | ||
| k8s.io/api => k8s.io/api v0.22.4 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.22.4 | ||
| k8s.io/client-go => k8s.io/client-go v0.22.4 |
Collaborator
There was a problem hiding this comment.
Do we still need these replacements?
Member
Author
There was a problem hiding this comment.
I'm fine removing them if you want to 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moby/buildkit@539be17...2f99651
Was testing if everything was ok while vendoring buildkit, specially otel upgrade and named contexts.
For k8s dependencies, I use a replace directive now for them otherwise we always use the deps from containerd module which is not what we really want when vendoring buildkit as it's specific for the k8s driver (#565, #775, ...). So should be done in follow-up if we want to. cc @AkihiroSuda @morlay.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com