Add JS libraries for jQuery.fileupload, jQuery.hoverIntent, and DNN jQuery Plugins#5724
Merged
david-poindexter merged 3 commits intodnnsoftware:developfrom Jul 7, 2023
Merged
Conversation
Contributor
Author
|
I also have a branch to package jQuery.hoverIntent and DNN plugins, not sure if we want that in this PR or a separate one… |
mitchelsellers
approved these changes
Jul 7, 2023
Contributor
|
@bdukes I think we can just make it one bit "Fix stuff that should have been libraries" This is a better solution! |
Contributor
Author
|
Works for me, I've updated this PR |
mitchelsellers
approved these changes
Jul 7, 2023
valadas
reviewed
Jul 7, 2023
david-poindexter
approved these changes
Jul 7, 2023
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Jul 15, 2023
The declaration in thirdparty.json was missed in dnnsoftware#5724 Closes dnnsoftware#5740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the special cases for
CommonJs.jQueryFileUpload,CommonJs.HoverIntent, andCommonJs.DnnPluginsby making them proper libraries (with dependencies).This will help the removal of obsolete APIs in DNN 10.0.0 #5722 to have a migration path.