Removal of API's Marked for 10.0.0 Removal#5722
Removal of API's Marked for 10.0.0 Removal#5722bdukes merged 11 commits intodnnsoftware:release/10.0.0from
Conversation
DNN Platform/Library/Framework/JavaScriptLibraries/JavaScript.cs
Outdated
Show resolved
Hide resolved
|
@mitchelsellers if you rebase it should fix the build issue with the GA4 connector |
|
#5729 needs to be merged first, right @valadas /cc @mitchelsellers |
|
Well I rebased, but things looked funny, I think @bdukes knows why! |
Oh, right, I thought it was already, sorry... So @mitchelsellers if you want to review/merge the other, then it should fix the build here after rebasing... |
6ca8aa5 to
61eef5a
Compare
|
This has been rebased |
|
I just pushed a commit which deleted the old |
|
@valadas If looks good, lets get this one in. I have a few other things I was going to work on but they would conflict with this PR so i want to get this one in if we can. |
|
Yes, it looks about right to me, I wanted to get the artifact from this and test a clean install and an upgrade but it looks like we have a broken install on the release/10.0.0 branch due to some dependency bumps. |
This pull request removes all API's that were flagged as "To Be Removed In v10.0.0". There are a few notes and special items to consider as part of the review of this PR, changes/suggestions/updates welcomed to ensure that we do this properly.
DotNetNuke.Library.Common.Utilities.IPathUtilsThe method for user folder paths is obsolete, but removing it causes a big break, i didn't remove itDotNetNuke.Services.Scheduling.SchedulingControllerthe method overload that was flagged as Obsolete was the wrong oneDotNetNuke.Services.Search.SearchEngineI had to make some changes to swallow fallback errors to prevent uncontrolled "not implemented" exceptions. Not sure that is the best way to do thisDotNetNuke.Framework.JavaScriptLibraries.JavaScript- A method was removed to support things for changes, want to be sure that it isn't a riskDotNetNuke.Providers.AspnetClientCapabilityProvider.AspnetClientCapabilityProvider- I'm not confident that the removal of the "Capabilities" property was proper, as I believe this regresses functionality.DotNetNuke.Framework.jQuerythe propertiesVersion,UIVersion- These also should have been marked as removed and managed by the packageMy apologies for the larger pull request, but I couldn't find a better way to try and make this "granular" to review/approve.