Updated GA4 Connector to build for DNN10#5729
Merged
mitchelsellers merged 2 commits intodnnsoftware:release/10.0.0from Jul 11, 2023
Merged
Updated GA4 Connector to build for DNN10#5729mitchelsellers merged 2 commits intodnnsoftware:release/10.0.0from
mitchelsellers merged 2 commits intodnnsoftware:release/10.0.0from
Conversation
This was making our build fail after rebasing the `release/10.0.0` branch from `develop` as GA4 was built on v9 and v10 was upgraded to use .Net framework 4.8. This should resolve this build issue...
bdukes
approved these changes
Jul 10, 2023
DNN Platform/Connectors/GoogleAnalytics4/Dnn.GoogleAnalytics4Connector.csproj
Outdated
Show resolved
Hide resolved
mitchelsellers
approved these changes
Jul 11, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Great catch @valadas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was making our build fail after rebasing the
release/10.0.0branch fromdevelopas GA4 was built on v9 and v10 was upgraded to use .Net framework 4.8.This should resolve this build issue...