Use stream framework to get max version#1526
Merged
jarifibrahim merged 3 commits intomasterfrom Sep 21, 2020
Merged
Conversation
NamanJain8
approved these changes
Sep 21, 2020
jarifibrahim
commented
Sep 21, 2020
ashish-goswami
approved these changes
Sep 21, 2020
Contributor
ashish-goswami
left a comment
There was a problem hiding this comment.
To calculate maxVersion of any key, this looks bit costly to me, given we will be reading all the keys(atleast first version). Otherwise
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jarifibrahim and @manishrjain)
jarifibrahim
pushed a commit
that referenced
this pull request
Sep 21, 2020
This PR adds a new `db.MaxVersion()` API that returns the maximum version across all keys in the DB. (cherry picked from commit 36af85f)
jarifibrahim
pushed a commit
that referenced
this pull request
Sep 21, 2020
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
This PR adds a new `db.MaxVersion()` API that returns the maximum version across all keys in the DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is