release/v2.2007 - feat(db): Add db.MaxVersion API (#1526)#1531
Merged
jarifibrahim merged 1 commit intorelease/v2.2007from Sep 21, 2020
Merged
release/v2.2007 - feat(db): Add db.MaxVersion API (#1526)#1531jarifibrahim merged 1 commit intorelease/v2.2007from
jarifibrahim merged 1 commit intorelease/v2.2007from
Conversation
This PR adds a new `db.MaxVersion()` API that returns the maximum version across all keys in the DB. (cherry picked from commit 36af85f)
manishrjain
suggested changes
Sep 21, 2020
Contributor
manishrjain
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
db.go, line 1836 at r1 (raw file):
stream.KeyToList = func(key []byte, itr *Iterator) (*pb.KVList, error) { maxVs := uint64(0) for ; itr.Valid(); itr.Next() {
Use ChooseKey instead.
jarifibrahim
commented
Sep 21, 2020
Contributor
Author
jarifibrahim
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami and @manishrjain)
db.go, line 1836 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Use ChooseKey instead.
Created a PR for this #1532 . This is a cherry-pick PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
db.MaxVersion()API that returns themaximum version across all keys in the DB.
(cherry picked from commit 36af85f)
This change is