-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Changed build_icons.yml to trigger on label added and create new pr #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f04de0b to
7cb7a4b
Compare
|
@amacado there's an issue with the "bot: build" label. When I check for it inside the build_icons.yml, GitHub complains that there's an error. Turns out that the ":" mess up the syntax, which means we have to rename the build label. Here are some variations that I tested that seems to work: Let me know what you think. I'll create a |
7cb7a4b to
a0df596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for bot:build as you suggested.
Also renamed our existing labels feature:icon and request:icon to match the syntax. I don't like spaces anyway ;-)
.github/workflows/build_icons.yml
Outdated
| commit_message: Build new icons, icomoon.json and devicon.css | ||
| COMMIT_MESSAGE: "Built new icons, icomoon.json and devicon.css" | ||
| PR_BRANCH_PREFIX: "build/feature/" | ||
| PR_BRANCH_NAME: "test-123" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe test-123 could a little more dynamic? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, sorry about that. I was in the middle of testing the trigger and wasn't sure how to do string interpolations in yml files.
|
@Thomas-Boi let me know when you're ready for a new review! 👍🏻 |
87321c5 to
ae7caa2
Compare
|
Hey @amacado, The workflow file now properly push any changes to a new branch and opens a PR on the triggered branch. This took awhile because I couldn't find an action on the marketplace that works for us. Features:
To test the script:
Note:
What's next:
Feel free to leave your comments or mess with the build file :). If you have any questions, I'll happily answer it. |
bot:build new icons, icomoon.json and devicon.css
amacado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thomas-Boi hello! Once again: Excellent work, happy to approve this pr! Been curious to test it on the pending pull requests #283, #284, #296, #297. Maybe you are willing to check one or two of those (or all ;-)) and try our updated workflow?
in my short test the delete-branch: true parameter did not work, i had to delete the branch manually, we should have an eye on it and see if this error stays or was just temporary.
Changed build_icons.yml to trigger on label added and create new pr

Hello guys,
This is the second part of the repo upgrade. This branch will be focusing on creating the new workflow as shown in this announcement.
The branch will be tested a couple times before it's ready to be merge. Please don't merge until I leave a comment saying that it's functional.
Cheers,