Skip to content

New icon: Flutter (plain, original) #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezSaldana wants to merge 4 commits into from
Closed

New icon: Flutter (plain, original) #296

ezSaldana wants to merge 4 commits into from

Conversation

@ezSaldana
Copy link
Contributor

@ezSaldana ezSaldana commented Sep 23, 2020

I closed the past pull request cause i forgot to create its own branch

Added flutter icon

I've added the plain and original flutter icons. Give it a check and let me know if there's something I should change.

Image

Screen Shot 2020-09-23 at 16 38 25

Issue Reference

#167

@amacado amacado changed the base branch from master to develop October 9, 2020 17:04
@Thomas-Boi
Copy link
Member

Thomas-Boi commented Oct 12, 2020

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Oct 21, 2020
@ezSaldana
Copy link
Contributor Author

ezSaldana commented Oct 22, 2020

Done!
Let me know if everything's ok!

@amacado amacado added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 22, 2020
amacado
amacado requested changes Oct 22, 2020
View reviewed changes
@amacado amacado removed the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 22, 2020
@ezSaldana
Copy link
Contributor Author

ezSaldana commented Oct 22, 2020

Ready, it was a typo.

@ezSaldana ezSaldana requested a review from amacado October 22, 2020 23:37
@amacado amacado added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 23, 2020
amacado
amacado requested changes Oct 23, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin looks good, just the foundation-issue left :)

image

@amacado amacado removed the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 23, 2020
@ezSaldana ezSaldana mentioned this pull request Oct 24, 2020
Closed
amacado
amacado requested changes Oct 24, 2020
View reviewed changes
@amacado amacado self-requested a review October 24, 2020 09:37
@ezSaldana ezSaldana closed this Oct 24, 2020
@ezSaldana ezSaldana deleted the flutter branch October 24, 2020 22:40
@ezSaldana ezSaldana mentioned this pull request Oct 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacado amacado Awaiting requested review from amacado

Assignees

@ezSaldana ezSaldana

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezSaldana @Thomas-Boi @amacado