Skip to content

disable push menu item when on detached HEAD#6992

Merged
outofambit merged 1 commit intodevelopmentfrom
disable-push-for-detached-head
Mar 4, 2019
Merged

disable push menu item when on detached HEAD#6992
outofambit merged 1 commit intodevelopmentfrom
disable-push-for-detached-head

Conversation

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 1, 2019

Overview

Addresses this bit of feedback from #6984:

the Push menu item is still active in the Repo menu, which triggers a console error:
Uncaught (in promise) Error: The current repository is in a detached HEAD state

Description

1.6.3-beta3:

This PR:

Release notes

Notes: no-notes

@shiftkey shiftkey added this to the 1.6.3 milestone Mar 1, 2019
@shiftkey shiftkey added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 1, 2019
@iAmWillShepherd iAmWillShepherd self-assigned this Mar 1, 2019
tierninho added a commit that referenced this pull request Mar 2, 2019
if rebase in progress, then New Branch menu option should be disabled as well to avoid confusion and error: 

`git -c credential.helper= -c protocol.version=2 checkout --progress cccc --recurse-submodules --` exited with an unexpected code: 1. 2-simple-rebase-conflict/LICENSE.md: needs merge, error: you need to resolve your current index first`

related to #6992
@tierninho
Copy link
Contributor

LGTM, added #6994 as well.

@outofambit outofambit self-assigned this Mar 4, 2019
@outofambit outofambit merged commit e4a7e23 into development Mar 4, 2019
@outofambit outofambit deleted the disable-push-for-detached-head branch March 4, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants