disable new branch for detached head#6994
Closed
tierninho wants to merge 1 commit intodisable-push-for-detached-headfrom
Closed
disable new branch for detached head#6994tierninho wants to merge 1 commit intodisable-push-for-detached-headfrom
tierninho wants to merge 1 commit intodisable-push-for-detached-headfrom
Conversation
if rebase in progress, then New Branch menu option should be disabled as well to avoid confusion and error: `git -c credential.helper= -c protocol.version=2 checkout --progress cccc --recurse-submodules --` exited with an unexpected code: 1. 2-simple-rebase-conflict/LICENSE.md: needs merge, error: you need to resolve your current index first` related to #6992
shiftkey
previously approved these changes
Mar 2, 2019
shiftkey
reviewed
Mar 2, 2019
| menuStateBuilder.setEnabled( | ||
| 'create-branch', | ||
| !tipStateIsUnknown && !branchIsUnborn | ||
| !tipStateIsUnknown && !branchIsUnborn && !onDetachedHead |
Member
There was a problem hiding this comment.
I'm not sure this is the complete fix because creating a branch from a detached HEAD is still a valid scenario. The issue description in #6335 shows the steps a user might do (requires terminal usage).
Member
|
Closing in favour of #7005 which is a more targeted fix for this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if rebase in progress, then
New Branchmenu option should be disabled as well to avoid confusion and error:git -c credential.helper= -c protocol.version=2 checkout --progress cccc --recurse-submodules --exited with an unexpected code: 1. 2-simple-rebase-conflict/LICENSE.md: needs merge, error: you need to resolve your current index first`related to #6992 and #6984
Feel free to close or edit if needed.