Stops node_modules from being cached during CI builds#6802
Merged
shiftkey merged 5 commits intodevelopmentfrom Feb 14, 2019
Merged
Stops node_modules from being cached during CI builds#6802shiftkey merged 5 commits intodevelopmentfrom
shiftkey merged 5 commits intodevelopmentfrom
Conversation
Member
|
@iAmWillShepherd are you able to add into this PR the change in time between this build and a recent successful build on |
shiftkey
reviewed
Feb 8, 2019
Member
This change is the one I worry about - it's already the slowest build, and this PR makes it even slower compared to the others. What if we left the change in #6799 in place for Appveyor only? |
7 tasks
shiftkey
reviewed
Feb 9, 2019
Co-Authored-By: iAmWillShepherd <iAmWillShepherd@users.noreply.github.com>
Member
|
@iAmWillShepherd I'm 👍 to getting this in and monitoring the build times over the |
iAmWillShepherd
added a commit
that referenced
this pull request
Feb 13, 2019
We removed the caching of node modules in #6802
Contributor
Author
|
Nope, this should be good. I went ahead and remove the work-around I was using to get CI to pass in a971a98 |
shiftkey
approved these changes
Feb 13, 2019
Member
|
Merging this in early to unblock some other CI work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the recent build issues we've been having due to cache invalidation.
Previous build times (range)
☝️ is given as ranges because I couldn't figure out how to export build history in order to do give better descriptive stats. Also all these times are from the past week.
After this change
Since these times are within the ranges I saw in our build history for successful builds, removing the cache doesn't seem to have made a significant impact.