downgrade spectron to known good version for Electron 2.x#6799
Merged
outofambit merged 2 commits intodevelopmentfrom Feb 8, 2019
Merged
downgrade spectron to known good version for Electron 2.x#6799outofambit merged 2 commits intodevelopmentfrom
outofambit merged 2 commits intodevelopmentfrom
Conversation
shiftkey
commented
Feb 8, 2019
| cache: | ||
| - .eslintcache | ||
| - node_modules | ||
| - node_modules -> package.json |
Member
Author
There was a problem hiding this comment.
This is the syntax Appveyor supports for saying "cache node_modules based on the contents of package.json" and this should help prevent cases like #6793 which I believe are down to cache invalidation not working as expected.
Member
Author
|
@outofambit I believe this will help with #6800 - feel free to cherry-pick the changes onto that branch |
outofambit
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is related to #6793 but I don't believe is the full resolution to why some builds are quietly failing their integration tests.
Description
spectronneeds to be updated at the same time Electron is updated, and the README shows how they relate:I jumped ahead to
5.0.0in #6518 because I assumed it'd be backwards compatibile with Electron 2 and I didn't see any issues at the time, but I suspect that's not accurate and is at least partly to blame for the issues we're seeing with the integration tests.Release notes
Notes: no-notes