port integration tests to jest#6518
Merged
iAmWillShepherd merged 9 commits intodevelopmentfrom Jan 17, 2019
Merged
Conversation
5bf14ba to
9c8a3c7
Compare
9c8a3c7 to
00e75fe
Compare
00e75fe to
d62d105
Compare
Member
Author
|
I extracted the last part of the Jest migration to #6645 because I wanted to keep this PR focused on porting the tests over. |
shiftkey
commented
Jan 16, 2019
| .getWindowCount() | ||
| .should.eventually.equal(1) | ||
| .browserWindow.isMinimized() | ||
| .should.eventually.be.false.browserWindow.isDevToolsOpened() |
Member
Author
There was a problem hiding this comment.
isDevToolsOpened() isn't exposed in the spectron typings because they just wrap electron - more context here: electron-userland/spectron#343
iAmWillShepherd
approved these changes
Jan 17, 2019
Contributor
iAmWillShepherd
left a comment
There was a problem hiding this comment.
Not sure what one of the new type definitions does. Since it doesn't have an associated dependency, can we add an short comment with some words on what dependency its supporting?
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
🌵🌵🌵builds upon #6517, go review that first 🌵🌵🌵The (almost) last part of moving away from
mochatojestis this PR.Description
Moving away from mocha requiring rewriting the launch test because we couldn't leverage
chai-as-promisedany more (which essentially promisified lots ofchai's API without having to think about it). Instead this test usesspectrondirectly to drive the app. I upgraded to the latestspectronbecause we've already been talking about Electron v3 support, but this also gave me a chance to use the typings that came in the box with thespectronpackage.The resulting code is more procedural but once I get some fixes upstream for the type declarations (everything is a promise-returning API it seems, despite what the typings might say) I feel much more confident in us writing more tests with it (because the magic is no longer hiding in libraries and BDD-esque syntax).
Release notes
Notes: no-notes