Skip to content

cleanup unused mocha/chai packages #6645

@shiftkey

Description

@shiftkey

After #6518 is reviewed and merged, we'll officially have no need to keep mocha and chai around. This means we should be able to remove these packages from the project:

  • @types/chai
  • @types/chai-datetime
  • chai
  • chai-as-promised
  • chai-datetime
  • mocha
  • mocha-junit-reporter
  • mocha-multi-reporters

As well as this test setup:

import { use } from 'chai'
use(require('chai-datetime'))

We can then drop this bit of documentation:

https://github.com/desktop/desktop/blob/933efd9761c1a5bf99697c3b478a7d73fae14d55/docs/technical/adding-tests.md#transitioning-to-jest

After doing that, you can check there are no outstanding issues by running these commands and ensuring the tests continue to pass:

$ yarn
$ yarn build:prod
$ yarn test

Metadata

Metadata

Labels

help wantedIssues marked as ideal for external contributorstech-debtIssues and pull requests related to addressing technical debt or improving the codebase

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions