Skip to content

Remove the chai and mocha packages#6688

Merged
outofambit merged 3 commits intodesktop:developmentfrom
Daniel-McCarthy:Drop-Chai-and-Mocha
Jan 23, 2019
Merged

Remove the chai and mocha packages#6688
outofambit merged 3 commits intodesktop:developmentfrom
Daniel-McCarthy:Drop-Chai-and-Mocha

Conversation

@Daniel-McCarthy
Copy link
Member

Overview

Closes #6645

Description

Release notes

Notes: no-notes

Since chai and mocha are no longer being used within the project now that  the tests have all been switched to use jest, we can now remove the packages directly.
Chai is no longer being used within the project, and therefore will be removed from all files.
This documentation explains the process of switching any existing chai tests to jest.

Currently there are no more chai tests left to convert, therefore chai is being removed from the project.

This documentation is no longer needed and is being removed.
@outofambit outofambit added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 22, 2019
Copy link
Contributor

@outofambit outofambit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exciting!

@outofambit outofambit self-assigned this Jan 22, 2019
@outofambit outofambit added this to the 1.6.2 milestone Jan 22, 2019
@shiftkey shiftkey added the tech-debt Issues and pull requests related to addressing technical debt or improving the codebase label Jan 22, 2019
@outofambit outofambit merged commit 676c705 into desktop:development Jan 23, 2019
@Daniel-McCarthy Daniel-McCarthy deleted the Drop-Chai-and-Mocha branch January 23, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Pull Requests that are ready to be reviewed by the maintainers tech-debt Issues and pull requests related to addressing technical debt or improving the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup unused mocha/chai packages

3 participants