cleanup chai usage from remaining unit tests#6521
Merged
shiftkey merged 6 commits intodesktop:developmentfrom Jan 3, 2019
Merged
cleanup chai usage from remaining unit tests#6521shiftkey merged 6 commits intodesktop:developmentfrom
shiftkey merged 6 commits intodesktop:developmentfrom
Conversation
Member
Author
|
@desktop/engineering not sure if the only running CircleCI is due to a PR targeting |
Member
|
@say25 I started bashing my head against these tests once I realised the issue yesterday, but NYE meant I didn't update the PR to add this context. Thinking on this some more, we can do this transition without continuing to stack pull requests:
Once both those are in, we can remove the packages from |
e5feba1 to
6871114
Compare
shiftkey
suggested changes
Jan 1, 2019
Co-Authored-By: say25 <say25@cornell.edu>
shiftkey
approved these changes
Jan 2, 2019
Member
|
@say25 thanks for helping migrate these over! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
Speeding up the migration from
mocha&chaitojest.Description
Release notes
Notes: No notes.