Skip to content

cleanup chai usage from remaining unit tests#6521

Merged
shiftkey merged 6 commits intodesktop:developmentfrom
say25:pour-out-chai
Jan 3, 2019
Merged

cleanup chai usage from remaining unit tests#6521
shiftkey merged 6 commits intodesktop:developmentfrom
say25:pour-out-chai

Conversation

@say25
Copy link
Member

@say25 say25 commented Jan 1, 2019

Overview

Speeding up the migration from mocha & chai to jest.

Description

  • Removing Chai usage in TypeScript Tests.

Release notes

Notes: No notes.

@say25
Copy link
Member Author

say25 commented Jan 1, 2019

@desktop/engineering not sure if the only running CircleCI is due to a PR targeting port-integration-tests-to-jest vs development branch but just wanted to call it out.

@say25 say25 mentioned this pull request Jan 1, 2019
2 tasks
@say25 say25 changed the title Remove Chai Expect Remove Chai Jan 1, 2019
@shiftkey
Copy link
Member

shiftkey commented Jan 1, 2019

@say25 I started bashing my head against these tests once I realised the issue yesterday, but NYE meant I didn't update the PR to add this context.

Thinking on this some more, we can do this transition without continuing to stack pull requests:

Once both those are in, we can remove the packages from package.json.

@shiftkey shiftkey force-pushed the port-integration-tests-to-jest branch from e5feba1 to 6871114 Compare January 1, 2019 14:49
@shiftkey shiftkey added the infrastructure Issues and pull requests related to scripts and tooling for GitHub Desktop label Jan 1, 2019
@say25 say25 changed the base branch from port-integration-tests-to-jest to development January 1, 2019 20:10
@shiftkey shiftkey changed the title Remove Chai cleanup chai usage from remaining unit tests Jan 1, 2019
Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

@shiftkey shiftkey added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 2, 2019
@shiftkey
Copy link
Member

shiftkey commented Jan 2, 2019

@say25 thanks for helping migrate these over!

@shiftkey shiftkey self-assigned this Jan 3, 2019
@shiftkey shiftkey merged commit f4efc0a into desktop:development Jan 3, 2019
@say25 say25 deleted the pour-out-chai branch January 3, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues and pull requests related to scripts and tooling for GitHub Desktop ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants