Split repository publication settings into two types#6776
Merged
shiftkey merged 25 commits intodevelopmentfrom Feb 22, 2019
Merged
Split repository publication settings into two types#6776shiftkey merged 25 commits intodevelopmentfrom
shiftkey merged 25 commits intodevelopmentfrom
Conversation
shiftkey
reviewed
Feb 5, 2019
Member
shiftkey
left a comment
There was a problem hiding this comment.
Haven't had a chance to test this out, but I wanted to call out some suggestions to be consistent with other areas.
719258a to
5b7ea78
Compare
shiftkey
reviewed
Feb 6, 2019
shiftkey
reviewed
Feb 6, 2019
4 tasks
Member
445d746 to
a75a9aa
Compare
a75a9aa to
14a82ef
Compare
Member
|
Please hold off on merging this PR - I want to use this branch to see if I can uncover why our integration tests are now failing. |
51de2d0 to
b4d5fed
Compare
8c44947 to
a5bdea9
Compare
a5bdea9 to
33e51b1
Compare
shiftkey
reviewed
Feb 21, 2019
Member
shiftkey
left a comment
There was a problem hiding this comment.
A bit of cleanup to make this new code easier to read, otherwise LGTM.
Co-Authored-By: iAmWillShepherd <iAmWillShepherd@users.noreply.github.com>
Co-Authored-By: iAmWillShepherd <iAmWillShepherd@users.noreply.github.com>
Co-Authored-By: iAmWillShepherd <iAmWillShepherd@users.noreply.github.com>
shiftkey
approved these changes
Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6546
Related to #6636.
This PR includes a refactor to better support #6636 with types. I've split the publication settings into two distinct types,
DotcomPublicationSettingsandGhePublicationSettings. This was done because we were previously sharing state between the two tabs which meant changes made in one tab would not persist once another tab was selected.From original PR
cc @brendonbarreto
Release notes
Notes: [Fixed] Publish settings remembered when switching between publish targets