add tracing to launch tests and emit details when test run fails#6789
Closed
shiftkey wants to merge 1 commit intomore-tabs-more-statefrom
Closed
add tracing to launch tests and emit details when test run fails#6789shiftkey wants to merge 1 commit intomore-tabs-more-statefrom
shiftkey wants to merge 1 commit intomore-tabs-more-statefrom
Conversation
Member
Author
|
Ugh, Travis isn't building because |
This was referenced Feb 7, 2019
b381e12 to
d949137
Compare
e0b138f to
81f1afe
Compare
Member
Author
|
Closing this out for now because I've not been able to reproduce the issue on a branch targeting the branch: I've politely asked @iAmWillShepherd to be able to push some commits to #6776 because that's consistently failing still. |
|
Sorry, please ignore the above-mentioned issue, mixed it up with another one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adding diagnostics to our Spectron tests to be able to diagnose what #6776 is doing on Travis that's causing it to be unable to launch.
Description
This leverages an old CI hook which reads out any log files that might exist in a known location if a CI failure occurs. I'm not sure it even still works for the original purpose, but this will help nicely for our Spectron tests where the internals can dump out logs to a known location to help us diagnose things where we can't SSH and run the tests directly.
If this approach works, we can revisit cleaning this area up to reflect what's actually valuable to us as part of diagnosing integration test failures better.
Release notes
Notes: no-notes