Keeping organization when switching tabs on publish repository modal#6636
Keeping organization when switching tabs on publish repository modal#6636brendonbribeiro wants to merge 5 commits intodesktop:developmentfrom brendonbribeiro:fix-tab-change
Conversation
|
Tested and LGTM however I could not test the Enterprise organization retention in the dev environment. |
|
Hi @brendonbarreto, thanks so much for submitting your first pull request in Desktop! 🎉 Our team is really focused on our 1.6 release scheduled to go out Thursday, so I don't anticipate a thorough review until after that. Welcome to the community and looking forward to hopefully getting this into the product. ❤️ |
|
Thanks for the welcome @billygriffin , and for the quick feedback! |
iAmWillShepherd
left a comment
There was a problem hiding this comment.
Not clearing out the org can create issues when the selection in the DotCom tab doesn't exist in the Enterprise tab. This change will require introducing some additional state to keep track of the selected org for each tab.
|
@iAmWillShepherd I made the changes you requested. Now each tab has its own state. Sorry for any mistake, I'm new to typescript world (but I already find it beautiful) I was not able to test enterprise tab . |
|
@brendonbarreto Have a look at #6776. I added a bit of type safety to what is being done in this PR. If it looks good to you, I can either push to your branch or we can go with the new PR (you'd still get credit of course 👍 ). |
|
@iAmWillShepherd I think we can go with the new PR (#6776) |
|
Closing due to #6636 (comment) |
This is my first PR to the project.
closes #6546