Skip to content

Feature: Open with other editor#21436

Merged
tidy-dev merged 3 commits intodesktop:developmentfrom
jackfreem:jf/OpenWithOtherEditor
Jan 13, 2026
Merged

Feature: Open with other editor#21436
tidy-dev merged 3 commits intodesktop:developmentfrom
jackfreem:jf/OpenWithOtherEditor

Conversation

@jackfreem
Copy link
Contributor

@jackfreem jackfreem commented Jan 7, 2026

Closes #21377
Closes #21297
Partially addresses painpoints from: #12195

Description

  • A common painpoint is to have Github Desktop open repos with preferences saved, so that it's not always the same editor. This is difficult from a product perspective, but we can ease the pain by adding on an additional option to 1-time open a repository with an alternate editor.
  • This uses the existing functionality for selecting an editor, but just doesn't save it.
  • It uses the Repository menu and the no-changes component to show these to the user.

Screenshots

Screenshot 2026-01-07 at 4 15 12 PM Screenshot 2026-01-07 at 4 15 35 PM Screenshot 2026-01-07 at 4 15 42 PM Screenshot 2026-01-07 at 4 15 49 PM

Release notes

Notes: Enable one-time opening of a repository in an alternate editor

Discussion

  • I think this should eventually be saved as a preference, so that each repo can default to a specific editor. This seems like an easier step in that direction.

@github-actions github-actions bot added external Pull request originating outside of the Desktop core team triage For incoming issues labels Jan 7, 2026
@jackfreem jackfreem marked this pull request as ready for review January 7, 2026 21:55
@DylanDevelops
Copy link
Contributor

I think the ability to save the external editor per project would be great, as some projects require different editors.

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackfreem Thanks for wanting to contribute! Discussed this with the Desktop team, and we are good with adding a menu item to the repository main menu. However, we don't want to add things to the "No local changes" screen. There are myriads of things we could put here, but we want to keep it focused with less options to think about.

I will be reviewing the rest of the changes more in depth, but wanted to go ahead and request removal of that change.

@jackfreem
Copy link
Contributor Author

@jackfreem Thanks for wanting to contribute! Discussed this with the Desktop team, and we are good with adding a menu item to the repository main menu. However, we don't want to add things to the "No local changes" screen. There are myriads of things we could put here, but we want to keep it focused with less options to think about.

I will be reviewing the rest of the changes more in depth, but wanted to go ahead and request removal of that change.

Happy to help - I'd like to followup with the functionality to save these preferences. I've looked through the related issues, but just wanted to flag this intent.

I've removed the changes from the default dash.

@jackfreem jackfreem requested a review from tidy-dev January 13, 2026 19:30
@tidy-dev
Copy link
Contributor

@jackfreem Thank your for that change -> I am reviewing the rest of the PR.

To respond to "like to followup with functionality to save these preferences".

Do you mean to close out #12195? As in, add an integrations area to the repository settings that is akin to the integrations area of the app preferences? .... or ... something else...

^ Reason I say this is that without getting consensus in the related issue with the Desktop team there is a chance we will not accept the PR simply on the grounds of we have not decided if that feature is something to add to Desktop yet. Additionally, the issue is where it is appropriate to discuss your approach and get feedback before creating a PR. For example, there was quite a bit of feedback given in #21297 (comment) to another contributor that did not start with consensus in the tracking issue.

TLDR; if you would like to put forward an intended approach to saving these preferences, please do so in the tracking issue (#12195) and get confirmation from a Desktop team member by tagging @desktop/engineering. We are small team and sometimes it takes time for us to respond.

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Works as expected on macOS and Windows.

@tidy-dev tidy-dev merged commit 3e6eaaf into desktop:development Jan 13, 2026
7 checks passed
Copy link

@thomaslovaslokoy-ui thomaslovaslokoy-ui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@kevingates
Copy link

Image

@tidy-dev : can we get this spam comment deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external Pull request originating outside of the Desktop core team triage For incoming issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ‘Open in Editor’ a one-click action from the file list

5 participants