Feature: Open with other editor#21436
Conversation
|
I think the ability to save the external editor per project would be great, as some projects require different editors. |
There was a problem hiding this comment.
@jackfreem Thanks for wanting to contribute! Discussed this with the Desktop team, and we are good with adding a menu item to the repository main menu. However, we don't want to add things to the "No local changes" screen. There are myriads of things we could put here, but we want to keep it focused with less options to think about.
I will be reviewing the rest of the changes more in depth, but wanted to go ahead and request removal of that change.
Happy to help - I'd like to followup with the functionality to save these preferences. I've looked through the related issues, but just wanted to flag this intent. I've removed the changes from the default dash. |
|
@jackfreem Thank your for that change -> I am reviewing the rest of the PR. To respond to "like to followup with functionality to save these preferences". Do you mean to close out #12195? As in, add an integrations area to the repository settings that is akin to the integrations area of the app preferences? .... or ... something else... ^ Reason I say this is that without getting consensus in the related issue with the Desktop team there is a chance we will not accept the PR simply on the grounds of we have not decided if that feature is something to add to Desktop yet. Additionally, the issue is where it is appropriate to discuss your approach and get feedback before creating a PR. For example, there was quite a bit of feedback given in #21297 (comment) to another contributor that did not start with consensus in the tracking issue. TLDR; if you would like to put forward an intended approach to saving these preferences, please do so in the tracking issue (#12195) and get confirmation from a Desktop team member by tagging |
tidy-dev
left a comment
There was a problem hiding this comment.
✨ Works as expected on macOS and Windows.
|
@tidy-dev : can we get this spam comment deleted? |


Closes #21377
Closes #21297
Partially addresses painpoints from: #12195
Description
Screenshots
Release notes
Notes:
Enable one-time opening of a repository in an alternate editorDiscussion