Add the ability to select editors on a per-repository basis#21297
Add the ability to select editors on a per-repository basis#21297sweezyio wants to merge 3 commits intodesktop:developmentfrom
Conversation
Updated AppStore, Dispatcher, and App components to pass the current repository when opening files or repositories in an external editor
|
Hey @sweezyio. Thanks for wanting to contribute. I want to set some clear expectations here. We currently have very limited capacity to review and accept PRs for features, especially ones we haven't made a clear decision on how to address. Getting this reviewed thoroughly could end up taking a long time. A very high level comment on this though is that WorkflowPreferences feels like the wrong place to host this. Workflow preferences is specifically about how the user wants to contribute to the repository (i.e. as an independent fork vs contributing to upstream). I reckon there's two possible approaches here. Either extend
Yes, I imagine users would be confused if we did not offer the ability to use a custom editor in a repository. I imagine this interface would be exactly the same as in the global preferences.
No. We have not seen the same request for custom shells per repository which makes sense, typically you'd use different editors based on the project but have a global shell. It being straightforward is not a good enough reason. |
Closes #12195
Description
Adds support for selecting editors on a per-repository basis that are different from the globally selected one.
Changes:
workflow-preferences.tsmodel to support storing a per-repository override of the globally selected external editorScreenshots
Release notes
Notes: Added per-repository external editor preferences in Repository Settings
Questions: