Fix crash in welcome flow when signing in to an endpoint that has an existing account#19442
Merged
sergiou87 merged 2 commits intodevelopmentfrom Oct 23, 2024
Merged
Fix crash in welcome flow when signing in to an endpoint that has an existing account#19442sergiou87 merged 2 commits intodevelopmentfrom
sergiou87 merged 2 commits intodevelopmentfrom
Conversation
sergiou87
approved these changes
Oct 23, 2024
Member
sergiou87
left a comment
There was a problem hiding this comment.
Code LGTM, tested it and worked as expected 👏
sergiou87
added a commit
that referenced
this pull request
Oct 23, 2024
Fix crash in welcome flow when signing in to an endpoint that has an existing account
|
gh pr checkout 19442 |
This comment was marked as spam.
This comment was marked as spam.
|
G |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing a bug introduced in #19342 that can cause a crash in the welcome flow due to inadequate handling of the ExistingAccountWarning state in the welcome flow.
Ways to reproduce:
..or...
I chose to address this in the sign in store rather than the Welcome flow so that any other callsites we might have in the future can benefit. I also considered simply ignoring the ExistingAccountWarning in the sign in store, but noticed that by doing so it could theoretically be possible to use the welcome flow to sign in to more than 2 (GH.com + GHE) accounts which I have no clue how the app would deal with.
Screenshots
Release notes
Notes: [Fixed] App no longer crash for first time users going through the welcome flow and attempting to sign in more than once.