Support entering GitHub.com as a GitHub Enterprise endpoint#19342
Merged
niik merged 6 commits intodevelopmentfrom Oct 9, 2024
Merged
Support entering GitHub.com as a GitHub Enterprise endpoint#19342niik merged 6 commits intodevelopmentfrom
niik merged 6 commits intodevelopmentfrom
Conversation
tidy-dev
reviewed
Oct 2, 2024
tidy-dev
reviewed
Oct 2, 2024
tidy-dev
reviewed
Oct 2, 2024
tidy-dev
reviewed
Oct 2, 2024
tidy-dev
reviewed
Oct 2, 2024
tidy-dev
reviewed
Oct 2, 2024
Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
This was referenced Oct 22, 2024
Merged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/desktop/issues/711
Description
There's a fair bit of confusion for users that have an Enterprise account (Enterprise Managed User) on GitHub.com when signing in. We present two options when signing in, either GitHub.com or GitHub Enterprise (we also mention AE which is a discontinued product).
For users of GitHub Enterprise on GitHub.com it's easy to assume that they should pick the "GitHub Enterprise" option but that historically only encompassed GitHub Enterprise Server (i.e. on-prem hosted GitHub). What we've seen from support requests is that these users will enter
github.comas the Enterprise endpoint and with our current production release that leads to a stalled sign in flow without any progress indication or error message.This PR aims to clarify the sign-in process for users by allowing them to enter
github.comas a valid endpoint for GitHub Enterprise, redirecting them to the appropriate sign-in flow.If we already have an account for GitHub.com we'll now show a warning that the account will be signed out if the user proceeds.
Screenshots
Release notes
Notes: