Fix custom integration args quotes#19224
Merged
sergiou87 merged 2 commits intodevelopmentfrom Sep 9, 2024
Merged
Conversation
tidy-dev
approved these changes
Sep 9, 2024
sergiou87
added a commit
that referenced
this pull request
Sep 9, 2024
…otes Fix custom integration args quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19218
Description
Based on top of #19223
This PR changes the way custom integration arguments are stored and handled across the app.
The parsing libraries used to split them into an array would remove any quotes from them, so they are stored correctly. However, when they're presented to the user in the preferences dialog, they would be joined into a string without those quotes. If they're then parsed and saved again, the resulting array of strings is completely different to what was stored before.
This PR makes it so that Desktop stores the exact string the user entered and only parses it into an array of strings when:
Unfortunately, this requires a migration of existing saved custom editors and shells. When the app starts, the custom integrations are loaded, Desktop will check if they need to be migrated and the migrated settings will be persisted.
Release notes
Notes: [Fixed] Quotes are not removed from custom integration arguments