Fix custom integration path validation for certain executables on Windows#19223
Merged
sergiou87 merged 2 commits intodevelopmentfrom Sep 9, 2024
Merged
Fix custom integration path validation for certain executables on Windows#19223sergiou87 merged 2 commits intodevelopmentfrom
sergiou87 merged 2 commits intodevelopmentfrom
Conversation
sergiou87
added a commit
that referenced
this pull request
Sep 9, 2024
Fix custom integration path validation for certain executables on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19217
Description
It seems some executables on Windows throw an EACESS error when trying to
statthem, but Desktop is still able to open them.The previous logic used
statto determine if the path points to a file or a directory. However, for executables I think we can get away with just usingaccess, and then on macOS we can still leveragestatto check if it points to a directory before trying to get its bundle ID.Release notes
Notes: [Fixed] Allow choosing certain Windows executables as custom editor or shell