fix(scrollable-region-focusable): clarify the issue is in safari#4995
Merged
WilcoFiers merged 1 commit intodevelopfrom Jan 29, 2026
Merged
fix(scrollable-region-focusable): clarify the issue is in safari#4995WilcoFiers merged 1 commit intodevelopfrom
WilcoFiers merged 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request clarifies that the scrollable-region-focusable rule is specifically a Safari browser issue by updating the rule's description metadata. This addresses confusion from users reporting false positives, as they were not aware this accessibility issue is Safari-specific. The PR description notes this is unusual for axe-core to call out a specific browser, but the overhead of maintaining this specificity is justified given the user confusion it resolves.
Changes:
- Updated the description field in the rule's JSON metadata to explicitly mention Safari
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "metadata": { | ||
| "description": "Ensure elements that have scrollable content are accessible by keyboard", | ||
| "description": "Ensure elements that have scrollable content are accessible by keyboard in Safari", | ||
| "help": "Scrollable region must have keyboard access" |
There was a problem hiding this comment.
The "help" text should also mention Safari for consistency with the updated "description" field. Users typically see the help text in accessibility testing tools, so it's important to clarify there as well that this is a Safari-specific issue. Consider updating to: "Scrollable region must have keyboard access in Safari"
Suggested change
| "help": "Scrollable region must have keyboard access" | |
| "help": "Scrollable region must have keyboard access in Safari" |
straker
approved these changes
Jan 26, 2026
Contributor
straker
left a comment
There was a problem hiding this comment.
We should make a similar change to the help docs.
WilcoFiers
added a commit
that referenced
this pull request
Mar 30, 2026
Part of #4830 Doesn't close the issue, but people keep reporting this as a false positive because we don't make it clear this is a Safari-only issue. Axe-core explicitly calling out a browser or screen reader is unusual, but I think the problem not doing this creates here is bigger than the overhead it would be for us to keep an eye on this and pull this out. If Safari ever addresses this the rule can be deprecated completely. See related Webkit bugs: - [WebKit#190870: Make scrollable element focusable](https://bugs.webkit.org/show_bug.cgi?id=190870) - [WebKit#277290: AX: Scrolling containers inoperable with keyboard](https://bugs.webkit.org/show_bug.cgi?id=277290)
straker
pushed a commit
that referenced
this pull request
Mar 30, 2026
Part of #4830 Doesn't close the issue, but people keep reporting this as a false positive because we don't make it clear this is a Safari-only issue. Axe-core explicitly calling out a browser or screen reader is unusual, but I think the problem not doing this creates here is bigger than the overhead it would be for us to keep an eye on this and pull this out. If Safari ever addresses this the rule can be deprecated completely. See related Webkit bugs: - [WebKit#190870: Make scrollable element focusable](https://bugs.webkit.org/show_bug.cgi?id=190870) - [WebKit#277290: AX: Scrolling containers inoperable with keyboard](https://bugs.webkit.org/show_bug.cgi?id=277290)
WilcoFiers
added a commit
that referenced
this pull request
Mar 31, 2026
### [4.11.2](v4.11.1...v4.11.2) (2026-03-30) ### Bug Fixes - **aria-valid-attr-value:** handle multiple aria-errormessage IDs ([#4973](#4973)) ([9322148](9322148)) - **aria:** prevent getOwnedVirtual from returning duplicate nodes ([#4987](#4987)) ([99d1e77](99d1e77)), closes [#4840](#4840) - **DqElement:** avoid calling constructors with cloneNode ([#5013](#5013)) ([88bc57f](88bc57f)) - **existing-rule:** aria-busy now shows an error message for a use with unallowed children ([#5017](#5017)) ([dded75a](dded75a)) - **scrollable-region-focusable:** clarify the issue is in safari ([#4995](#4995)) ([2567afd](2567afd)), closes [WebKit#190870](https://github.com/dequelabs/WebKit/issues/190870) [WebKit#277290](https://github.com/dequelabs/WebKit/issues/277290) - **scrollable-region-focusable:** do not fail scroll areas when all content is visible without scrolling ([#4993](#4993)) ([240f8b5](240f8b5)) - **target-size:** determine offset using clientRects if target is display:inline ([#5012](#5012)) ([69d81c1](69d81c1)) - **target-size:** ignore widgets that are inline with other inline elements ([#5000](#5000)) ([cf8a3c0](cf8a3c0))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4830
Doesn't close the issue, but people keep reporting this as a false positive because we don't make it clear this is a Safari-only issue. Axe-core explicitly calling out a browser or screen reader is unusual, but I think the problem not doing this creates here is bigger than the overhead it would be for us to keep an eye on this and pull this out. If Safari ever addresses this the rule can be deprecated completely.
See related Webkit bugs: