Skip to content

fix(ext/node): set process.features.inspector#31863

Closed
bartlomieju wants to merge 7 commits intodenoland:mainfrom
bartlomieju:enable_inspector
Closed

fix(ext/node): set process.features.inspector#31863
bartlomieju wants to merge 7 commits intodenoland:mainfrom
bartlomieju:enable_inspector

Conversation

@bartlomieju
Copy link
Copy Markdown
Member

process.features.inspector was set to false which causes inspector tests to be skipped and giving false positive results.

bartlomieju added a commit that referenced this pull request Jan 16, 2026
This almost correctly implements `process.features`, the only missing
bit is `process.features.inspector` which will be handled in
#31863 because it requires to
disable a bunch of tests that were false positives.

Makes `parallel/test-process-features.js` test pass.
bartlomieju added a commit that referenced this pull request Jan 20, 2026
…31881)

This commit changes arg parsing for `--inspect`, `--inspect-brk` and
`--inspect-wait` flag
to allow passing values as follows:
- `127.0.0.1` -> `127.0.0.1:9229`
- `192.168.0.1` -> `192.168.0.1:9229`
- `:10000` -> `127.0.0.1:10000`
- `10000` -> `127.0.0.1:10000`
- `:0` -> `127.0.0.1:<OS assigned port>`
- `0` -> `127.0.0.1:<OS assigned port>`
This matches what Node.js is doing and will help to solve test
compatiblity discovered in #31863.
bartlomieju added a commit that referenced this pull request Jan 20, 2026
…e server a global (#31895)

This commit moves the implementation of `InspectorServer` to 
a new `deno_inspector_server` crate, this change is required because
this struct is used in both `runtime/` and `ext/node/` crate which
requires to have a crate that both can use.

Additionally the inspector server has been made a singleton global that
can be created and retrieved by all crates using it, which is a
prerequisite for implementing #31863.
@bartlomieju
Copy link
Copy Markdown
Member Author

Closing in favor of #31898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant